<div dir="ltr">For: <br>
[ 13-test-signal-compare_obj.diff ]<br>
[ 17-signal-rule-cleanup.diff ]<br>[ 21-test-signal-rename-tests.diff ]<br><br>Acked-by: Kshitij Gupta <<a href="mailto:kgupta8592@gmail.com" target="_blank">kgupta8592@gmail.com</a>></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 17, 2015 at 2:23 AM, Christian Boltz <span dir="ltr"><<a href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Hello,<br>
<br>
Am Freitag, 23. Oktober 2015 schrieb Christian Boltz:<br>
</span><span class="">> this patch adds the SignalRule and SignalRuleset classes<br>
<br>
</span>Here's the third patch on top:<br>
<br>
[patch] Rename some test-signal tests<br>
<br>
signal tests with "net" in their name don't look like a good idea ;-)<br>
<span class=""><br>
<br>
I'll commit this together with 07-add-SignalRule-and-SignalRuleset.diff<br>
</span>(and slightly adjust 12-logprof-signal.diff for the changed name)<br>
<br>
<br>
[ 21-test-signal-rename-tests.diff ]<br>
<br>
=== modified file ./utils/test/test-signal.py<br>
--- utils/test/test-signal.py 2015-11-16 21:36:19.467063449 +0100<br>
+++ utils/test/test-signal.py 2015-11-16 00:14:05.371336371 +0100<br>
@@ -88,7 +88,7 @@<br>
SignalRule.parse(rawrule)<br>
<br>
class SignalTestParseFromLog(SignalTest):<br>
- def test_net_from_log(self):<br>
+ def test_signal_from_log(self):<br>
<span class=""> parser = ReadLog('', '', '', '', '')<br>
</span> event = 'type=AVC msg=audit(1409438250.564:201): apparmor="DENIED" operation="signal" profile="/usr/bin/pulseaudio" pid=2531 comm="pulseaudio" requested_mask="send" denied_mask="send" signal=term peer="/usr/bin/pulseaudio///usr/lib/pulseaudio/pulse/gconf-helper"'<br>
<br>
@@ -187,7 +187,7 @@<br>
<span class=""><br>
self.assertIsNone(obj, 'SignalRule handed back an object unexpectedly')<br>
<br>
</span>- def test_invalid_net_missing_comma(self):<br>
+ def test_invalid_signal_missing_comma(self):<br>
<span class=""> self._check_invalid_rawrule('signal') # missing comma<br>
<br>
</span> def test_invalid_non_SignalRule(self):<br>
<br>
<br>
<br>
<br>
<br>
Regards,<br>
<br>
Christian Boltz<br>
<span class="HOEnZb"><font color="#888888">--<br>
> Womit erstellt ihr so eure Homepages?<br>
mit vim *g*. Wobei es Leute gibt, die tatsächlich behaupten, das soll<br>
auch mit diesem Betriebssystem - wie heißt es doch gleich - *äh* Emacs<br>
gehen. <SCNR> [> Bernd Stäglich und Philipp Zacharias in suse-linux]<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/apparmor" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div>Regards,<br><br></div>Kshitij Gupta<br></div></div>
</div>