<div dir="ltr"><div>Oops... I was sure I did a "Reply to all".<br><br></div>Thanks. :-)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 25, 2015 at 1:05 AM, Christian Boltz <span dir="ltr"><<a href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
I assume that was meant for the mailinglist ;-)<br>
<br>
<br>
----- Weitergeleitete Nachricht -----<br>
Von: Kshitij Gupta <<a href="mailto:kgupta8592@gmail.com">kgupta8592@gmail.com</a>><br>
An: Christian Boltz <<a href="mailto:apparmor@cboltz.de">apparmor@cboltz.de</a>><br>
Betreff: Re: [apparmor] [patch] Add network mpls and ib to rule/network.py and the apparmor.d manpage<br>
Datum: Dienstag, 25. August 2015<br>
<div><div class="h5"><br>
Hello,<br>
<br>
On Mon, Aug 24, 2015 at 11:17 PM, Christian Boltz <<a href="mailto:apparmor@cboltz.de">apparmor@cboltz.de</a>><br>
wrote:<br>
<br>
> Hello,<br>
><br>
> $subject.<br>
><br>
> Those two showed up in apparmor.vim when building on latest openSUSE<br>
> tumbleweed.<br>
><br>
> The manpage change should also go into 2.9, but since we are missing<br>
> more network domain keywords (and various other things), that should<br>
> be done as a big merge patch.<br>
><br>
><br>
> [ 84-add-network-mpls-ib.diff ]<br>
><br>
> === modified file ./utils/apparmor/rule/network.py<br>
> --- utils/apparmor/rule/network.py 2015-07-17 00:19:58.574811968 +0200<br>
> +++ utils/apparmor/rule/network.py 2015-08-24 19:33:00.445291390 +0200<br>
> @@ -27,7 +27,7 @@<br>
> network_domain_keywords = [ 'unix', 'inet', 'ax25', 'ipx', 'appletalk',<br>
> 'netrom', 'bridge', 'atmpvc', 'x25', 'inet6',<br>
> 'rose', 'netbeui', 'security', 'key',<br>
> 'netlink', 'packet', 'ash', 'econet', 'atmsvc', 'rds', 'sna',<br>
> 'irda', 'pppox', 'wanpipe', 'llc', 'can',<br>
> 'tipc', 'bluetooth', 'iucv', 'rxrpc', 'isdn', 'phonet',<br>
> - 'ieee802154', 'caif', 'alg', 'nfc', 'vsock'<br>
> ]<br>
> + 'ieee802154', 'caif', 'alg', 'nfc',<br>
> 'vsock', 'mpls', 'ib' ]<br>
><br>
> network_type_keywords = ['stream', 'dgram', 'seqpacket', 'rdm',<br>
> 'raw', 'packet']<br>
> network_protocol_keywords = ['tcp', 'udp', 'icmp']<br>
> --- parser/apparmor.d.pod 2015-07-11 14:26:30.374110864 +0200<br>
> +++ parser/apparmor.d.pod 2015-08-24 19:34:08.893196537 +0200<br>
> @@ -103,7 +103,7 @@<br>
><br>
> B<NETWORK RULE> = [ I<QUALIFIERS> ] 'network' [ I<DOMAIN> ] [ I<TYPE> |<br>
> I<PROTOCOL> ]<br>
><br>
> -B<DOMAIN> = ( 'inet' | 'ax25' | 'ipx' | 'appletalk' | 'netrom' | 'bridge'<br>
> | 'atmpvc' | 'x25' | 'inet6' | 'rose' | 'netbeui' | 'security' | 'key' |<br>
> 'packet' | 'ash' | 'econet' | 'atmsvc' | 'sna' | 'irda' | 'pppox' |<br>
> 'wanpipe' | 'bluetooth' | 'netlink' | 'unix' | 'rds' | 'llc' | 'can' |<br>
> 'tipc' | 'iucv' | 'rxrpc' | 'isdn' | 'phonet' | 'ieee802154' | 'caif' |<br>
> 'alg' | 'nfc' | 'vsock' ) ','<br>
> +B<DOMAIN> = ( 'inet' | 'ax25' | 'ipx' | 'appletalk' | 'netrom' | 'bridge'<br>
> | 'atmpvc' | 'x25' | 'inet6' | 'rose' | 'netbeui' | 'security' | 'key' |<br>
> 'packet' | 'ash' | 'econet' | 'atmsvc' | 'sna' | 'irda' | 'pppox' |<br>
> 'wanpipe' | 'bluetooth' | 'netlink' | 'unix' | 'rds' | 'llc' | 'can' |<br>
> 'tipc' | 'iucv' | 'rxrpc' | 'isdn' | 'phonet' | 'ieee802154' | 'caif' |<br>
> 'alg' | 'nfc' | 'vsock' | 'mpls' | 'ib' ) ','<br>
><br>
> B<TYPE> = ( 'stream' | 'dgram' | 'seqpacket' | 'rdm' | 'raw' | 'packet' )<br>
><br>
><br>
><br>
> Thanks for the patch.<br>
<br>
Acked-by: Kshitij Gupta <<a href="mailto:kgupta8592@gmail.com">kgupta8592@gmail.com</a>><br>
<br>
<br>
> Regards,<br>
><br>
> Christian Boltz<br>
> --<br>
> Life used to be simpler when apple and blackberry were just fruits!<br>
> [from <a href="https://bugzilla.novell.com/quips.cgi" rel="noreferrer" target="_blank">https://bugzilla.novell.com/quips.cgi</a>]<br>
><br>
><br>
> --<br>
> AppArmor mailing list<br>
> <a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
> Modify settings or unsubscribe at:<br>
> <a href="https://lists.ubuntu.com/mailman/listinfo/apparmor" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br>
><br>
<br>
<br>
<br>
--<br>
Regards,<br>
<br>
Kshitij Gupta<br>
</div></div>-------------------------------------<br>
<br>
<br>
Regards,<br>
<br>
Christian Boltz<br>
<span class="HOEnZb"><font color="#888888">--<br>
The original author of this email is Ludwig Nussel, but I edited it a<br>
bit before sending. That means that the good parts are from him, and<br>
the mistakes are mine. [Alberto Planas Dominguez in opensuse-factory]<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/apparmor" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div>Regards,<br><br></div>Kshitij Gupta<br></div></div>
</div>