<div dir="ltr">Hello,<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 25, 2015 at 5:20 AM, Christian Boltz <span dir="ltr"><<a href="mailto:apparmor@cboltz.de" target="_blank">apparmor@cboltz.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
when switching the audit flag for network events in aa-logprof<br>
(technically, it happens in aa.py ask_the_question()), the "(I)gnore"<br>
button gets "lost".<br>
<br>
This patch fixes the list of available buttons.<br>
<br>
<br>
I propose this patch for trunk and 2.9.<br>
<br>
<br>
[ 26-logprof-fix-buttons-after-audit.diff ]<br>
<br>
=== modified file utils/apparmor/aa.py<br>
--- utils/apparmor/aa.py        2015-05-25 00:47:50.323591893 +0200<br>
+++ utils/apparmor/aa.py        2015-05-25 01:45:28.597491886 +0200<br>
@@ -2009,10 +2009,10 @@<br>
                                 audit = ''<br>
                                 if audit_toggle:<br>
                                     audit = 'audit'<br>
-                                    q.functions = ['CMD_ALLOW', 'CMD_DENY', 'CMD_AUDIT_OFF',<br>
+                                    q.functions = ['CMD_ALLOW', 'CMD_DENY', 'CMD_IGNORE_ENTRY', 'CMD_AUDIT_OFF',<br>
                                                       'CMD_ABORT', 'CMD_FINISHED']<br>
                                 else:<br>
-                                    q.functions = ['CMD_ALLOW', 'CMD_DENY', 'CMD_AUDIT_NEW',<br>
+                                    q.functions = ['CMD_ALLOW', 'CMD_DENY', 'CMD_IGNORE_ENTRY', 'CMD_AUDIT_NEW',<br>
                                                       'CMD_ABORT', 'CMD_FINISHED']<br>
                                 q.headers = [_('Profile'), combine_name(profile, hat)]<br>
                                 q.headers += [_('Network Family'), audit + family]<br>
<br></blockquote><div>Not sure if why it happens in other cases(if it does), here a possible reasoning would be "if user selected Audit button, they dont wish to ignore it".<br><br>That said giving more options to user doesn't seem like a bad idea.<br><br><div>Thanks for the patch.<br> <br></div><div>Acked-by: Kshitij Gupta <<a href="mailto:kgupta8592@gmail.com" target="_blank">kgupta8592@gmail.com</a>>. <br><br></div><div>Regards,<br><br></div>Kshitij Gupta<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Regards,<br>
<br>
Christian Boltz<br>
<span class=""><font color="#888888">--<br>
[...] sollte für einen Ortskundigen also kinderleicht zu finden sein.<br>
Wir sind die Leute, die den dicken weißgrünen Europcar Lastwagen so<br>
bescheuert mitten auf der Straße geparkt haben.<br>
[Kristian Köhntopp zieht um]<br>
<br>
<br>
--<br>
AppArmor mailing list<br>
<a href="mailto:AppArmor@lists.ubuntu.com">AppArmor@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/apparmor" target="_blank">https://lists.ubuntu.com/mailman/listinfo/apparmor</a><br>
</font></span></blockquote></div><br></div></div>