[apparmor] [PATCH v2 3/8] utils: Require apparmor.aa users to call init_aa()

[Christian Boltz]

Hello,

Am Donnerstag, 2. März 2017, 21:47:25 CET schrieb Tyler Hicks:
> On 03/02/2017 01:32 PM, Christian Boltz wrote:
> > Am Mittwoch, 1. März 2017, 21:52:01 CET schrieb Tyler Hicks:

> >> --- a/utils/test/Makefile
> >> +++ b/utils/test/Makefile
> >> 
> >>  check: __libapparmor
> >> 
> >> -	export PYTHONPATH=$(PYTHONPATH) ; export
> >> LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) ; export LC_ALL=C; $(foreach
> >> test,
> >> $(wildcard test-*.py), echo ; echo === $(test) === ; $(call
> >> pyalldo,
> >> $(test)))
> >> +	export PYTHONPATH=$(PYTHONPATH)
> >> LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) LC_ALL=C __AA_CONFDIR=$(CONFDIR)
> >> ;
> >> $(foreach test, $(wildcard test-*.py), echo ; echo === $(test) ===
> >> ;
> >> $(call pyalldo, $(test)))
> > 
> > I remember discussions about line lenghts in python. Did we already
> > have such a discussion about Makefiles? ;-)
> 
> Hmm? I don't recall what you're referring to. 

The discussion about line lengths in python was a long time ago, so I'm 
not even surprised ;-)

> Are you wanting me to
> wrap the lines that I modified?

Yes, that would be a good idea.

Actually we have that "export ..." twice (in "check:" and ".coverage"), 
so it would be even better to move it to a variable with a short 
name ;-)

> I strongly prefer to follow existing conventions when making feature
> changes or bug fixes and leave coding style cleanups to separate
> patches.

Yeah, that's also what I usually do ;-)

> > (I know changing this in this patch would break the following
> > patches, so if you want shorter lines, feel free to send a
> > follow-up patch.)
> FYI, this sort of thing isn't a problem with git rebase (I use
> git-remote-bzr for apparmor devel).

The next patches added more variables to exactly this line, so I'd guess 
even git will give you merge conflicts ;-)


Something more interesting - as already discussed on IRC, your changes 
broke minitools_test.py [1]. Since you now own both parts, I won't 
object if you fix it in whatever way ;-)


Regards,

Christian Boltz

[1] it is not part of "make check" because it's not named test-*.py

-- 
> The proposal makes no sense till all the bugs are solved.
What we need is a list of all unknown bugs.  ;-)
[> Carlos E. R. and James Knott in opensuse-factory]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170302/4af186ec/attachment.pgp>