[apparmor] [PATCH 2/2] libapparmor: Don't print shell commands that check for test failures

Tyler Hicks tyhicks at canonical.com
Thu Apr 20 19:32:41 UTC 2017


On 04/20/2017 02:28 PM, Tyler Hicks wrote:
> Error messages shouldn't show up in build logs when the error has been
> encountered. This patch silences these shell commands from being printed
> before they're interpreted.

Typo in the first sentence above. Changed locally to:

"Error messages should only show up in build logs when the error has
been encountered."

Tyler

> 
> Signed-off-by: Tyler Hicks <tyhicks at canonical.com>
> ---
>  libraries/libapparmor/testsuite/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libraries/libapparmor/testsuite/Makefile.am b/libraries/libapparmor/testsuite/Makefile.am
> index 2cde5cc..55dcb68 100644
> --- a/libraries/libapparmor/testsuite/Makefile.am
> +++ b/libraries/libapparmor/testsuite/Makefile.am
> @@ -18,7 +18,7 @@ clean-local:
>  	rm -f libaalogparse.log libaalogparse.sum
>  
>  check-local: check-DEJAGNU
> -	if ! test -f libaalogparse.log ; then echo '*** libaalogparse.log not found - is dejagnu installed? ***'; exit 1; fi
> -	if grep ERROR libaalogparse.log ; then exit 1 ; fi
> +	@if ! test -f libaalogparse.log ; then echo '*** libaalogparse.log not found - is dejagnu installed? ***'; exit 1; fi
> +	@if grep ERROR libaalogparse.log ; then exit 1 ; fi
>  
>  EXTRA_DIST = test_multi/*.in test_multi/*.out test_multi/*.err
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170420/d2a7da4b/attachment.pgp>


More information about the AppArmor mailing list