[apparmor] [patch] [08/38] Drop dead code in aa.py handle_children()

Christian Boltz apparmor at cboltz.de
Wed Sep 14 14:38:29 UTC 2016


Hello,

Am Mittwoch, 14. September 2016, 00:27:48 CEST schrieb Seth Arnold:
> On Fri, Aug 12, 2016 at 10:48:13PM +0200, Christian Boltz wrote:

> > -                    else:
> > +
> > +                    if True:
> >                          options = cfg['qualifiers'].get(exec_target,
> >                          'ipcnu')
> >                          
> >                          if to_name:
> >                              fatal_error(_('%s has transition name
> >                              but not transition mode') % entry)
> It could drop a bit more if you removed the 'if True:' line and all
> those needless spaces :D

Right, but it would also make the patch completely unreadable ;-)

140 lines of whitespace change are clearly worth a separate patch that 
does _only_ whitespace changes. I just added that to my TODO list ;-)


Regards,

Christian Boltz
-- 
vielen Dank für den Link. Der ging ja neulich schon mal über die Liste
und ich habe die Seiten ganz schnell wieder zugemacht und mir die
Lektüre für kalte Wintertage vorbehalten - dummerweise funktioniert
unsere Heizung aber hervorragend ... [Tao te Puh in opensuse-de]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160914/fdd83419/attachment.pgp>


More information about the AppArmor mailing list