[apparmor] [patch] Drop loadincludes() and mode_to_str() tests from aa_test.py

Steve Beattie steve at nxnw.org
Mon Oct 10 20:12:14 UTC 2016


On Sun, Oct 09, 2016 at 08:07:53PM +0200, Christian Boltz wrote:
> aa_test.py doesn't run in 'make check' because its filename doesn't
> match the 'test-*.py' pattern.
> 
> mode_to_str() was dropped as part of the FileRule series, so it's
> pointless to keep its tests. (The replacement is totally different and
> has full test coverage already.)
> 
> loadincludes() still exists, but only testing if the function runs
> without errors is not really helpful, so drop this test.
> 
> Also drop unused imports and add an explicit import for apparmor.aamode.
> 
> [ 03-drop-old-tests-from-aa_test.diff ]
> 
Acked-by: Steve Beattie <steve at nxnw.org>. Thanks.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20161010/1cd318c9/attachment.pgp>


More information about the AppArmor mailing list