[apparmor] [PATCH v2 3/5] Makefile: Convert shell variables into reusable make variables

[Tyler Hicks]

On 2016-01-26 19:47:53, Seth Arnold wrote:
> On Tue, Jan 26, 2016 at 06:58:24PM -0600, Tyler Hicks wrote:
> > I'll need to think about this a bit more before I can propose a better
> > solution.
> 
> While you're working on this block it'd be nice to replace "make" with
> $(MAKE) -- that lets the -j job scheduler work in the recursive makes,
> along with the -t -n -q options.
> 
> I opened https://bugs.launchpad.net/apparmor/+bug/1536548 for this
> recently, but it's not a large enough priority to fix on its own. But if
> you're there already... :)

I looked into this and the top level Makefile isn't the only place where
this change needs to happen. After reading the Makefile docs on this
subject, I don't think this is as simple as a s/make/\$\(MAKE\)/g and
there are some subtleties that will need really good testing to make
sure we don't break anything.

I'll try to circle back to this a little later as it'll take a bit too
much time to do now.

Tyler

> 
> Thanks



> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160127/16074a33/attachment.pgp>