[apparmor] [PATCH 1/3] Makefile: Reorder DIRS variable according to build order

Christian Boltz apparmor at cboltz.de
Wed Jan 6 11:54:32 UTC 2016


Hello,

Am Dienstag, 5. Januar 2016 schrieb Tyler Hicks:
> Order the DIRS variable according to build order. This allows the DIRS
> variable to be iterated over to build libapparmor, binutils, utils,
> parser, etc., without having to reorder the list.
> 
> Signed-off-by: Tyler Hicks <tyhicks at canonical.com>
> ---
>  Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index f7907cd..5a9ba73 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -8,13 +8,13 @@ all:
>  COMMONDIR=common
>  include ${COMMONDIR}/Make.rules
> 
> -DIRS=parser \
> -     profiles \
> -     utils \
> +DIRS=libraries/libapparmor \
>       binutils \
> -     libraries/libapparmor \
> +     utils \
> +     parser \

Can you change that order a bit to make it more useful if we ever come 
up with a global "make test"?

The utils tests nowadays use the parser simple_tests to make sure 
parsing profiles doesn't result in unexpected results (valid vs. invalid 
syntax).

However, lots of the simple_tests are autogenerated in the parser "make 
test" run, so that should be done first to ensure the utils test can test 
everything.

So long story short, please change the patch to

...
+     parser \
+     utils \
...

With that changed,
    Acked-by: Christian Boltz <apparmor at cboltz.de>


Regards,

Christian Boltz
-- 
Dieser Indizierungsmurks. Semantikgefuckel, dass das System
unbenutzbar macht.
Aber gut, dass man zwei Knie hat, in die man sich schießen kann.
[Lars Müller in opensuse-de]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160106/4357806b/attachment.pgp>


More information about the AppArmor mailing list