[apparmor] [patch] Add SignalRule and SignalRuleset classes
Christian Boltz
apparmor at cboltz.de
Fri Oct 23 18:19:07 UTC 2015
Hello,
Am Freitag, 23. Oktober 2015 schrieb Christian Boltz:
> this patch adds the SignalRule and SignalRuleset classes
> Also add a set of tests (100% coverage :-) to make sure everything
> works as expected.
> [ 07-add-SignalRule-and-SignalRuleset.diff ]
Here's a small patch on top:
Check everything in test-signal.py _compare_obj()
(Comparison of peer and all_peers was missing.)
I'll commit this together with 07-add-SignalRule-and-SignalRuleset.diff,
but didn't want to resend the big patch just because two lines were
missing.
[ 13-test-signal-compare_obj.diff ]
=== modified file ./utils/test/test-signal.py
--- utils/test/test-signal.py 2015-10-23 19:53:08.922615849 +0200
+++ utils/test/test-signal.py 2015-10-23 19:40:17.146900973 +0200
@@ -35,8 +35,10 @@
self.assertEqual(expected.audit, obj.audit)
self.assertEqual(expected.access, obj.access)
self.assertEqual(expected.signal, obj.signal)
+ self.assertEqual(expected.peer, obj.peer)
self.assertEqual(expected.all_accesss, obj.all_accesss)
self.assertEqual(expected.all_signals, obj.all_signals)
+ self.assertEqual(expected.all_peers, obj.all_peers)
self.assertEqual(expected.deny, obj.deny)
self.assertEqual(expected.comment, obj.comment)
Regards,
Christian Boltz
--
> You say our final product doesn't have bugs worth tracking?
No. Your final products are in general known for their bugginess.
This could be a marketing decision to assure your jobs. ;-))
[> Stephan Kulow and Eberhard Mönkeberg in opensuse-factory]
More information about the AppArmor
mailing list