[apparmor] [patch] load_include(): use include_dir_filelist()

Christian Boltz apparmor at cboltz.de
Sat Oct 3 21:18:47 UTC 2015


Am Sonntag, 13. September 2015 schrieb Christian Boltz:
> load_include() used a custom os.listdir call instead of
> include_dir_filelist() for directory includes, which means it also
> read skippable files like *.rpmnew or README. (It seems nobody
> created a README inside an included directory, otherwise we'd have
> seen a bugreport ;-)
> This patch changes load_include() to use include_dir_filelist(). This
> function is used in some more places already and removes skippable
> files from the file list.
> Unfortunately 2.9 doesn't have the include_dir_filelist() function
> yet, which makes backporting this patch harder than I like. Therefore
> I won't backport it unless someone complains very loudly ;-)
> [ 90-load_include-use-include_dir_filelist.diff ]

Any comments or reviews on this patch?

If nobody objects, I'll commit it on Wednesday as Acked-by <timeout>.


Christian Boltz
<jjohansen> this change is inconsistent with what we do now
<jjohansen> however what we do now is broken
[from #apparmor]

More information about the AppArmor mailing list