[apparmor] [PATCH 7/9] Convert Makefile to use static pattern rules

Christian Boltz apparmor at cboltz.de
Sat Oct 3 20:16:53 UTC 2015


Hello,

Am Montag, 14. September 2015 schrieb John Johansen:
> instead of individual rules for each .c or .cc file use static pattern
> rules and variables to get automatic expansion.
> 
> For the current patch keep the dependencies for various header
> combinations separate as they currently are. However this patch fixes
> several missing dependencies, including the missing dependencies on
> parser_version.h, af_names.h and cap_names.h which necessitating
> splitting and adding new dependencies.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>

I like the patch in general, however there are some minor issues:

> --- a/parser/Makefile
> +++ b/parser/Makefile

[reordered to make understanding easier]

> -parser_yacc.o: parser_yacc.c parser_yacc.h $(HDRS) $(APPARMOR_H)
> +C_OBJS_AA = parser_yacc.o
> +$(C_OBJS_AA): %.o: %.c $(HDRS) $(APPARMOR_H)

parser_yacc.h is not part of HDRS - please keep it as dependency of 
C_OBJS_AA

> -network.o: network.c $(HDRS) $(APPARMOR_H)
> +C_OBJS_YACC_AF = network.o
> +$(C_OBJS_YACC_AF): %.o: %.c parser_yacc.h af_names.h $(HDRS)

you "lost" APPARMOR_H for network.o - please add it back.


With these two bugs fixed,
    Acked-by: Christian Boltz <apparmor at cboltz.de>


Regards,

Christian Boltz
-- 
Please resolve this as NOT A BUG and USER SHOULD HAVE MORE COFFEE BEFORE
FILING BUGS.  I apologize for taking up valuable developer time!
[Jon Nelson in https://bugzilla.novell.com/show_bug.cgi?id=776271#c2]




More information about the AppArmor mailing list