[apparmor] [PATCH 2/9] Cleanup libapparmor_re Makefile to use patterns

[Christian Boltz]

Hello,

Am Montag, 14. September 2015 schrieb John Johansen:
> Signed-off-by: John Johansen <john.johansen at canonical.com>
> ---
>  parser/libapparmor_re/Makefile | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/parser/libapparmor_re/Makefile
> b/parser/libapparmor_re/Makefile index f66702a..c8d9db6 100644
> --- a/parser/libapparmor_re/Makefile
> +++ b/parser/libapparmor_re/Makefile
> @@ -20,19 +20,14 @@ BISON := bison
>  all : ${TARGET}
> 
>  UNITTESTS = tst_parse
> +SRCS = expr-tree.cc hfa.cc aare_rules.cc chfa.cc parse.cc
> +HDRS = expr-tree.h hfa.h aare_rules.h chfa.h apparmor_re.h
> flex-tables.h ../immunix.h 
> +OBJS = $(SRCS:.cc=.o)
[...]

Seth already mentioned that parse.h needs to be added to HDRS.

Besides that, the patch only adds some (maybe superfluous, maybe missed-
until-now) dependencies, but the Makefile maintenance simplification is 
worth that. Therefore (with parse.h added to HDRS)
    Acked-by: Christian Boltz <apparmor at cboltz.de>

I'd even argue that you should just use *.cc and *.h wildcards instead 
of listing files individually - if you like that idea, feel free to 
change that before commiting ;-)


Regards,

Christian Boltz
-- 
> Sensation: Ratti schreibt Doku!
> :-)
Olle ätzende Giftspritze! :-)
[> Christian Boltz und Ratti in fontlinge-devel]