[apparmor] Pending patches

Christian Boltz apparmor at cboltz.de
Sun Nov 15 21:30:03 UTC 2015


Hello,

some of my patches are waiting for a review since october:

==> 01-profile_storage-debug-info.diff <==
Add debug info to profile_storage()

==> 02-utils-test-Makefile-pythonpath-libapparmor.diff <==
utils/test/Makefile: add libapparmor to PYTHONPATH

==> 03-add-match-group-to-RE_PROFILE_SIGNAL.diff <==
add a named match group to RE_PROFILE_SIGNAL

==> 07-add-SignalRule-and-SignalRuleset.diff <==
Add SignalRule and SignalRuleset classes

==> 08-adjust-tests-to-use-SignalRule.diff <==
Adjust test-signal_parse.py to use SignalRule

==> 09-use-SignalRule.diff <==
Change aa.py to use SignalRule and SignalRuleset

==> 10-cleanprof-more-rule-types.diff <==
Update cleanprof to also delete superfluous signal etc. rules

==> 11-mergeprof-support-rlimit-and-signal.diff <==
Add support for rlimit and signal rules to aa-mergeprof

==> 12-logprof-signal.diff <==
Add support for signal log events to aa-logprof

==> 13-test-signal-compare_obj.diff <==
Check everything in test-signal.py _compare_obj()

==> 14-move-test-signal_parse-tests-to-test-signal.diff <==
Move all tests from test-signal_parse.py to test-signal.py

==> 17-signal-rule-cleanup.diff <==
Cleanup SignalRule a bit

==> 18-fix-bare-file-rule.diff <==
Fix parsing/storing bare file rules

==> utils-Makefile-pymodules.diff <==
update PYMODULES in tools/Makefile


Any comments or reviews on those patches?

If nobody objects, I'll commit them on Wednesday as Acked-by <timeout>. 
Needless to say that an additional pair of eyes looking at them would be 
a good idea ;-)


I intentionally did not list

==> 15-aare-class-and-tests.diff <==
AARE class

==> 16-signal-rule-use-aare.diff <==
Change SignalRule to use AARE instead of plain strings

because I'm working on v2 with some improvements and corner-case fixes. 
Log events containing regex chars like *, ? or {...} need to be escaped 
and OTOH, we can use the un-escaped expression to improve match(). This 
also means AARE __init__() needs a log_event parameter.

If someone is very fast in reviewing the AARE patches, I'll send the 
improvements as separate patch. Otherwise expect v2 in the next days ;-)


Regards,

Christian Boltz
-- 
A pair of extra monkeys under Coolo's charge would probably help
more... It's clear to us that Coolo's days have now 36 hours...
[Nelson Marques in opensuse-factory]




More information about the AppArmor mailing list