[apparmor] [PATCH 19/20] Extend change_profile tests
Christian Boltz
apparmor at cboltz.de
Fri May 29 21:01:00 UTC 2015
Hello,
Am Freitag, 29. Mai 2015 schrieb John Johansen:
> .../tst/simple_tests/change_profile/onx_aa_ok_1.sd | 0
> .../tst/simple_tests/change_profile/onx_aa_ok_2.sd | 0
> .../tst/simple_tests/change_profile/onx_aa_ok_3.sd | 0
> .../tst/simple_tests/change_profile/onx_aa_ok_4.sd | 0
> .../tst/simple_tests/change_profile/onx_aa_ok_5.sd | 0
> .../tst/simple_tests/change_profile/onx_aa_ok_6.sd | 0
> .../tst/simple_tests/change_profile/onx_aa_ok_7.sd | 0
> .../tst/simple_tests/change_profile/onx_aa_ok_8.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_1.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_2.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_3.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_4.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_5.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_6.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_7.sd | 0
> .../simple_tests/change_profile/onx_aa_re_ok_8.sd | 0
...
> .../simple_tests/change_profile/onx_allowo_ok_1.sd | 0
> .../simple_tests/change_profile/onx_allowo_ok_2.sd | 0
> .../simple_tests/change_profile/onx_allowo_ok_3.sd | 0
> .../simple_tests/change_profile/onx_allowo_ok_4.sd | 0
> .../simple_tests/change_profile/onx_allowo_ok_5.sd | 0
> .../simple_tests/change_profile/onx_allowo_ok_6.sd | 0
> .../simple_tests/change_profile/onx_allowo_ok_7.sd | 0
> .../simple_tests/change_profile/onx_allowo_ok_8.sd | 0
> .../change_profile/onx_allowo_re_ok_1.sd | 0
> .../change_profile/onx_allowo_re_ok_2.sd | 0
> .../change_profile/onx_allowo_re_ok_3.sd | 0
> .../change_profile/onx_allowo_re_ok_4.sd | 0
> .../change_profile/onx_allowo_re_ok_5.sd | 0
> .../change_profile/onx_allowo_re_ok_6.sd | 0
> .../change_profile/onx_allowo_re_ok_7.sd | 0
> .../change_profile/onx_allowo_re_ok_8.sd | 0
...
> .../simple_tests/change_profile/onxbad_aa_ok_1.sd | 0
> .../simple_tests/change_profile/onxbad_aa_ok_2.sd | 0
> .../simple_tests/change_profile/onxbad_aa_ok_3.sd | 0
> .../simple_tests/change_profile/onxbad_aa_ok_4.sd | 0
> .../simple_tests/change_profile/onxbad_aa_ok_5.sd | 0
> .../simple_tests/change_profile/onxbad_aa_ok_6.sd | 0
> .../simple_tests/change_profile/onxbad_aa_ok_7.sd | 0
> .../simple_tests/change_profile/onxbad_aa_ok_8.sd | 0
> .../change_profile/onxbad_aa_re_ok_1.sd | 0
> .../change_profile/onxbad_aa_re_ok_2.sd | 0
> .../change_profile/onxbad_aa_re_ok_3.sd | 0
> .../change_profile/onxbad_aa_re_ok_4.sd | 0
> .../change_profile/onxbad_aa_re_ok_5.sd | 0
> .../change_profile/onxbad_aa_re_ok_6.sd | 0
> .../change_profile/onxbad_aa_re_ok_7.sd | 0
> .../change_profile/onxbad_aa_re_ok_8.sd | 0
...
> .../change_profile/onxbad_allowo_ok_1.sd | 0
> .../change_profile/onxbad_allowo_ok_2.sd | 0
> .../change_profile/onxbad_allowo_ok_3.sd | 0
> .../change_profile/onxbad_allowo_ok_4.sd | 0
> .../change_profile/onxbad_allowo_ok_5.sd | 0
> .../change_profile/onxbad_allowo_ok_6.sd | 0
> .../change_profile/onxbad_allowo_ok_7.sd | 0
> .../change_profile/onxbad_allowo_ok_8.sd | 0
> .../change_profile/onxbad_allowo_re_ok_1.sd | 0
> .../change_profile/onxbad_allowo_re_ok_2.sd | 0
> .../change_profile/onxbad_allowo_re_ok_3.sd | 0
> .../change_profile/onxbad_allowo_re_ok_4.sd | 0
> .../change_profile/onxbad_allowo_re_ok_5.sd | 0
> .../change_profile/onxbad_allowo_re_ok_6.sd | 0
> .../change_profile/onxbad_allowo_re_ok_7.sd | 0
> .../change_profile/onxbad_allowo_re_ok_8.sd | 0
...
> .../simple_tests/change_profile/onxre_aa_ok_1.sd | 0
> .../simple_tests/change_profile/onxre_aa_ok_2.sd | 0
> .../simple_tests/change_profile/onxre_aa_ok_3.sd | 0
> .../simple_tests/change_profile/onxre_aa_ok_4.sd | 0
> .../simple_tests/change_profile/onxre_aa_ok_5.sd | 0
> .../simple_tests/change_profile/onxre_aa_ok_6.sd | 0
> .../simple_tests/change_profile/onxre_aa_ok_7.sd | 0
> .../simple_tests/change_profile/onxre_aa_ok_8.sd | 0
> .../change_profile/onxre_aa_re_ok_1.sd | 0
> .../change_profile/onxre_aa_re_ok_2.sd | 0
> .../change_profile/onxre_aa_re_ok_3.sd | 0
> .../change_profile/onxre_aa_re_ok_4.sd | 0
> .../change_profile/onxre_aa_re_ok_5.sd | 0
> .../change_profile/onxre_aa_re_ok_6.sd | 0
> .../change_profile/onxre_aa_re_ok_7.sd | 0
> .../change_profile/onxre_aa_re_ok_8.sd | 0
...
> .../change_profile/onxre_allowo_ok_1.sd | 0
> .../change_profile/onxre_allowo_ok_2.sd | 0
> .../change_profile/onxre_allowo_ok_3.sd | 0
> .../change_profile/onxre_allowo_ok_4.sd | 0
> .../change_profile/onxre_allowo_ok_5.sd | 0
> .../change_profile/onxre_allowo_ok_6.sd | 0
> .../change_profile/onxre_allowo_ok_7.sd | 0
> .../change_profile/onxre_allowo_ok_8.sd | 0
> .../change_profile/onxre_allowo_re_ok_1.sd | 0
> .../change_profile/onxre_allowo_re_ok_2.sd | 0
> .../change_profile/onxre_allowo_re_ok_3.sd | 0
> .../change_profile/onxre_allowo_re_ok_4.sd | 0
> .../change_profile/onxre_allowo_re_ok_5.sd | 0
> .../change_profile/onxre_allowo_re_ok_6.sd | 0
> .../change_profile/onxre_allowo_re_ok_7.sd | 0
> .../change_profile/onxre_allowo_re_ok_8.sd | 0
...
> .../simple_tests/change_profile/onxvar_aa_ok_1.sd | 0
> .../simple_tests/change_profile/onxvar_aa_ok_2.sd | 0
> .../simple_tests/change_profile/onxvar_aa_ok_3.sd | 0
> .../simple_tests/change_profile/onxvar_aa_ok_4.sd | 0
> .../simple_tests/change_profile/onxvar_aa_ok_5.sd | 0
> .../simple_tests/change_profile/onxvar_aa_ok_6.sd | 0
> .../simple_tests/change_profile/onxvar_aa_ok_7.sd | 0
> .../simple_tests/change_profile/onxvar_aa_ok_8.sd | 0
> .../change_profile/onxvar_aa_re_ok_1.sd | 0
> .../change_profile/onxvar_aa_re_ok_2.sd | 0
> .../change_profile/onxvar_aa_re_ok_3.sd | 0
> .../change_profile/onxvar_aa_re_ok_4.sd | 0
> .../change_profile/onxvar_aa_re_ok_5.sd | 0
> .../change_profile/onxvar_aa_re_ok_6.sd | 0
> .../change_profile/onxvar_aa_re_ok_7.sd | 0
> .../change_profile/onxvar_aa_re_ok_8.sd | 0
...
> .../change_profile/onxvar_allowo_ok_1.sd | 0
> .../change_profile/onxvar_allowo_ok_2.sd | 0
> .../change_profile/onxvar_allowo_ok_3.sd | 0
> .../change_profile/onxvar_allowo_ok_4.sd | 0
> .../change_profile/onxvar_allowo_ok_5.sd | 0
> .../change_profile/onxvar_allowo_ok_6.sd | 0
> .../change_profile/onxvar_allowo_ok_7.sd | 0
> .../change_profile/onxvar_allowo_ok_8.sd | 0
> .../change_profile/onxvar_allowo_re_ok_1.sd | 0
> .../change_profile/onxvar_allowo_re_ok_2.sd | 0
> .../change_profile/onxvar_allowo_re_ok_3.sd | 0
> .../change_profile/onxvar_allowo_re_ok_4.sd | 0
> .../change_profile/onxvar_allowo_re_ok_5.sd | 0
> .../change_profile/onxvar_allowo_re_ok_6.sd | 0
> .../change_profile/onxvar_allowo_re_ok_7.sd | 0
> .../change_profile/onxvar_allowo_re_ok_8.sd | 0
This patch comes with quite some empty files ;-)
Besides that, my comments from the 13/20 review also apply here:
- please rename FAILing testcases to *_bad_*
- please split FAILing testcases to one failure per file
- please add a hint in the DESCRIPTION explaining why a test is expected
to FAIL
Regards,
Christian Boltz
--
Dann siehst du nämlich ganz genau, daß der Cursor blinkt, und er
hat feuerrote tote Augen, mit denen er dich anstarrt und brüllt:
".. UND WENN DU DICH VERTIPPST, DANN FRESSE ICH DICH MITSAMT
DEINEM MAUSZEIGER!!!!" [Ratti in suse-programming]
More information about the AppArmor
mailing list