[apparmor] [PATCH] add --include-template-dir and --include-policy-groups-dir to easyprof

[Jamie Strandboge]

On 03/27/2015 11:34 PM, Seth Arnold wrote:
> On Fri, Mar 27, 2015 at 11:12:14PM -0500, Jamie Strandboge wrote:
>>> Is this warn() correct? for the similar error of missing templates you're
>>> using exit().
>>>
>>
>> I did warn() instead of error() because you can only show one template per
>> invocation whereas you can show multiple groups with just one. The previous
>> behavior was to simply traceback, which is a form of exit I suppose. I don't
>> feel strongly either way so if you have a preference for error(), I'm happy to
>> change it.
> 
> No, I'm sure this is fine; I just noticed something that felt out of place.
> 
After sleeping on it, I think I prefer error() now because with what I proposed
it would indeed warn for missing groups, but then would display the other ones
such that the warning would scroll off the screen and be easily missed and
therefore not be of much use. Using error() restores previous behavior of
exiting non-zero.

Thanks for the feedback, committing with error() and for the comment correction.

I also meant to nominate this for 2.9.

-- 
Jamie Strandboge                 http://www.ubuntu.com/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150328/52cfe6c5/attachment.pgp>