[apparmor] [PATCH 05/10] Update qualifier information in the man page

Christian Boltz apparmor at cboltz.de
Fri Mar 20 12:34:27 UTC 2015


Hello,

Am Freitag, 20. März 2015 schrieb John Johansen:
> Consolidate and update the qualifier information in the man page.
> Most of the rule qualifiers where duplicated instead of being pulled
> into a common section.
> 
> Also the rule qualifiers where missing the 'allow' qualifier.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>
> ---
>  parser/apparmor.d.pod | 38 ++++++++++++++++++++------------------
>  1 file changed, 20 insertions(+), 18 deletions(-)
> 
> diff --git a/parser/apparmor.d.pod b/parser/apparmor.d.pod
> index db5ea0e..70d9c8c 100644
> --- a/parser/apparmor.d.pod
> +++ b/parser/apparmor.d.pod
...
> -B<FILE RULE> = I<RULE QUALIFIER> ( '"' I<FILEGLOB> '"' | I<FILEGLOB>
> ) I<ACCESS> ',' -
> -B<RULE QUALIFIER> = [ 'audit' ] [ 'deny' ] [ 'owner' ]
> +B<FILE RULE> = I<FILE QUALIFIERS> ( '"' I<FILEGLOB> '"' | I<FILEGLOB>
> ) I<ACCESS> ','

Please write that as
    B<FILE RULE> = [ I<QUALIFIERS> ] [ 'owner' ] ( '"' I<FILEGLOB> '"' ...

This has two advantages:
- it uses <QUALIFIERS> which is used everywhere else in the manpage
- when someone reads the manpage quickly, he might overlook the 
  difference between <QUALIFIERS> and <FILE QUALIFIERS>. An explicit 
  'owner' is more visible.

>  B<FILEGLOB> = (must start with '/' (after variable expansion),
> B<AARE> have special meanings; see below. May include I<VARIABLE>.
> Rules with embedded spaces or tabs must be quoted. Rules must end
> with '/' to apply to directories.)
> 
> +B<FILE QUALIFIERS> [ I<QUALIFIERS> ] [ 'owner' ]

With the above changed, this addition is superfluous.

With that changed,
Acked-by: Christian Boltz <apparmor at cboltz.de>


Regards,

Christian Boltz
-- 
ist eine recht interessante rechnung:
3,5kg linux + bücher für €79,90
180g windows xp home ohne bücher €229,-
kennt jemand den feinunzenpreis von gold? er müßte kanpp unter
dem von windows liegen ....   [Wilhelm Feichter in suse-linux]




More information about the AppArmor mailing list