[apparmor] [PATCH 1/2] Fix compilation failure of deny link rules

[Christian Boltz]

Hello,

Am Donnerstag, 19. März 2015 schrieb John Johansen:
> BugLink: http://bugs.launchpad.net/bugs/1433829
> 
> The apparmor_parser fails to compile deny rules with only link
> permissions.
> 
>   Eg.
>        deny /f l,
>        deny l /f,
>        deny link /f -> /d,
> 
> Will all fail to compile with the following assert
> 
>   apparmor_parser: aare_rules.cc:99: Node* convert_file_perms(int,
> uint32_t, uint32_t, bool): Assertion `perms != 0' failed.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>
> ---
>  parser/parser_regex.c                                | 3 ++-
>  parser/tst/simple_tests/file/okay_audit_deny_link.sd | 9 +++++++++
>  parser/tst/simple_tests/file/okay_deny_link.sd       | 9 +++++++++

The usual naming scheme for tests is ok_*.sd, not okay_*.sd [1]. Please 
adjust the filenames to ok_*.sd.

Besides that, the added tests look good.


Regards,

Christian Boltz

[1] with 3 exceptions in the mount rule tests - if you want to rename 
    those okay_*.sd to ok_*.sd, feel free to add 
        Acked-by: Christian Boltz <apparmor at cboltz.de>

-- 
>Programmieren in C++ hält die grauen Zellen am Leben.
Es schaerft alle fuenf Sinne: den Schwachsinn, den Bloedsinn,
den Wahnsinn, den Unsinn und den Stumpfsinn.
[Felix von Leitner und Holger Veit in doc]