[apparmor] [PATCH 1/3] Add support for variable expansion in profile names, and attachments

Christian Boltz apparmor at cboltz.de
Wed Jun 17 22:46:35 UTC 2015


Hallo Leute,

Am Mittwoch, 17. Juni 2015 schrieb John Johansen:
> --- /dev/null
> +++ b/parser/tst/simple_tests/vars/vars_profile_name_09.sd
> @@ -0,0 +1,9 @@
> +#=DESCRIPTION reference variables in rules that also have
> alternations +#=EXRESULT PASS
> +
> +@{FOO}=bar
> +@{BAR}=baz
> +
> +profile /does/not@{BAR} /exist@{FOO} {
> +  /does/not/exist r,
> +}

I see no alternation, so either fix the test or the description ;-)

> --- /dev/null
> +++ b/parser/tst/simple_tests/vars/vars_profile_name_13.sd
> @@ -0,0 +1,11 @@
> +#=DESCRIPTION reference variables in rules that also have
> alternations +#=EXRESULT FAIL
> +#=TODO
> +# This test needs check on @{FOO} attachment having leading / post
> var expansion +
> +@{FOO}=bar
> +@{BAR}=baz
> +
> +profile @{BAR} @{FOO} {
> +  /does/not/exist r,
> +}

Same here.

With these two fixed,
    _tests_ Acked-by: Christian Boltz <apparmor at cboltz.de>

I'll leave the review of parser_variable.c and parser_yacc.y for someone 
else ;-)


Regards,

Christian Boltz
-- 
Wenn du in deiner procmail spamassassin stehen hast, dann wird für
jede eintrudelnde Mail das komplette Programm gestartet, inclusive
Initialisierung und PiPaPo - also, ich mache meine Wohnung am liebsten
mit der Zentralheizung warm, nicht mit meiner Festplatte. ;-)
[Ratti in suse-linux]




More information about the AppArmor mailing list