[apparmor] [PATCH 4/4] libapparmor: Provide privately exported aa_is_blacklisted() through swig

Tyler Hicks tyhicks at canonical.com
Tue Jun 16 18:29:47 UTC 2015

On 2015-06-16 13:14:15, Christian Boltz wrote:
> Hello,
> Am Montag, 15. Juni 2015 schrieb Tyler Hicks:
> > +/* swig doesn't like the macro magic we do in apparmor.h an 
> > apparmor_private.h
> You have a little typo here - s/an/and/, please ;-)


> That said - thanks for this patch series!
> To answer your comment in another mail: yes, I'll handle the python side 
> of things - the first step will probably be to run the 
> is_skippable_file() tests against _aa_is_blacklisted() ;-)
> BTW: The function definition is
>     int _aa_is_blacklisted(const char *name, const char *path)
> but "path" is never used inside the function. Is this intentional?

Nice catch. No, it isn't intentional. I'll fix it in a follow up patch
and will include the rational in the commit message.

There's an additional follow up patch that I'll also be sending that
prevents crazy exceptions from being raised by
LibAppArmor._aa_is_blacklisted() in some situations.

Do I have your ACK on this patch?


> Regards,
> Christian Boltz
> -- 
> [Canterbury] I received mine yesterday and installed it on my new dual
> quad-core machine w/ 16G of ram. what a screaming OS. Some commands even
> finish _before_ I hit the enter key. [Ken Schneider in opensuse-factory]
> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150616/a5e6027c/attachment.pgp>

More information about the AppArmor mailing list