[apparmor] [PATCH 10/14] Fix: refactor change_profile to deal with unexpected TOK_ID error

[Steve Beattie]

On Thu, Jun 04, 2015 at 03:56:39AM -0700, John Johansen wrote:
> bison isn't properly handling the 3 options of
> 
> TOK_CHANGE_PROFILE opt_id TOK_END_OF_RULE
> TOK_CHANGE_PROFILE opt_id TOK_ARROW TOK_ID TOK_END_OF_RULE
> TOK_CHANGE_PROFILE opt_id TOK_ARROW TOK_COLON TOK_ID TOK_COLON TOK_END_OF_RULE
> 
> specifying
>   change_profile /exec,
> 
> results in an unexpected TOK_ID error

I'm not able to reproduce this failure with patch 08 applied...

> refactor so that they share the 3 options share a common head which fixes
> the problem.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>

however, I have no objection to refactoring this way, such that the test
for a valid onexec pattern is de-duplicated.

Acked-by: Steve Beattie <steve at nxnw.org>

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150608/6091636e/attachment.pgp>