[apparmor] [utils] [patch] Remove re import from cleanprofile.py

Christian Boltz apparmor at cboltz.de
Sun Jun 7 19:31:39 UTC 2015


Hello,

Am Sonntag, 7. Juni 2015 schrieb Kshitij Gupta:
> The following patch:
> - removes re import
> - uses apparmor.re_match_include instead of the regex

Nice cleanup :-) (which also means to use the correct regex instead of 
the slightly wrong one cleanprofile.py had)

> === modified file 'utils/apparmor/cleanprofile.py'
> --- utils/apparmor/cleanprofile.py      2015-06-07 17:58:53 +0000
> +++ utils/apparmor/cleanprofile.py      2015-06-07 18:05:50 +0000
> @@ -11,8 +11,6 @@
>  #    GNU General Public License for more details.
>  #
>  #
> ---------------------------------------------------------------------
> -import re
> -
>  import apparmor.aa as apparmor
> 
>  class Prof(object):
> @@ -92,7 +90,7 @@
>                      if not same_profile:
>                          deleted.append(entry)
>                  continue
> -            if re.search('#?\s*include', rule) or
> re.search('#?\s*include', entry):
> +            if apparmor.re_match_include(rule) or
> apparmor.re_match_include(entry):
>                  continue

Acked-by: Christian Boltz <apparmor at cboltz.de>


Regards,

Christian Boltz
-- 
> Das hatte ich (samt Kommentar aus der /etc/postfix/transport) doch
> schon in meiner letzten Mail erklärt ... ;)
Sandy ist schuld ;-)
Erst mit seiner Erklärung ist mir aufgefallen, dass ich es nicht
verstanden habe. [> David Haller und Peter Mc Donough in opensuse-de]




More information about the AppArmor mailing list