[apparmor] [PATCH 2/2] Set cache file tstamp to the mtime of most recent policy file tstamps

Christian Boltz apparmor at cboltz.de
Sat Jun 6 13:49:49 UTC 2015


Hello,

Am Freitag, 5. Juni 2015 schrieb John Johansen:
> Currently the cache file has its mtime set to its creation time, but
> this can lead to cache issues when a policy file is updated
> separately from the cache file so that is possible a policy file is
> newer than the what the cache file was generated from but still fails
> the comparison because the generated cache file has a newer
> timestamp.

This avoids quite some packaging problems, thanks!

Bonus question: would it make sense to

a) [simple change] let the cache check look for the exact timestamp 
   (maybe with +/- 1 second) instead of "cache is newer than all files 
   involved in the profile"?

b) [more difficult change] store the timestamp (or even a checksum) of 
   all files involved in the profile/cache file?

(Whatever the answer is - this is something for a follow-up patch.)


Regards,

Christian Boltz
-- 
The goal is simple: no more gnome related bugs in the 12.2 release :)
(ok, we ARE optimists).   [Dominique Leuenberger in opensuse-factory]




More information about the AppArmor mailing list