[apparmor] [PATCH 13/14] Extend change_profile tests

Christian Boltz apparmor at cboltz.de
Fri Jun 5 22:27:33 UTC 2015


Hello,

Am Donnerstag, 4. Juni 2015 schrieb John Johansen:
> --- /dev/null
> +++ b/parser/tst/simple_tests/change_profile/onxvar_aao_re_bad_4.sd
> @@ -0,0 +1,52 @@
> +#
> +#=DESCRIPTION owner not allowed in change_profile rule
> +#=EXRESULT FAIL
> +#
> +
> +@{LIBVIRT}="libvirt"
> +@{LIBVIRT_RE}="libvirt*"
> +
> +@{var}=/test
> +/usr/bin/foo {
> +   audit allow owner change_profile @{var} -> @{LIBVIRT}-fo*,
> +}
> +
> +/usr/bin/foo2 {
> +   audit allow owner change_profile @{var} -> @{LIBVIRT}-fo**,
> +}
> +
> +/usr/bin/foo3 {
> +   audit allow owner change_profile @{var} -> @{LIBVIRT}-fo[ab],
> +}
[...]

Please split this file to one failure per file.

Same for

> +++ b/parser/tst/simple_tests/change_profile/onxvar_aao_re_bad_4.sd

which also contains multiple failures.


Besides this, the FAIL testcases look good. (I didn't check the PASS 
testcases because they already looked good in the first version of the 
patch ;-)


Regards,

Christian Boltz
-- 
Irgendwie habe ich bei SSL-Kram immer das Gefühl, das ich auf einer
sehr dünnen Eisschicht über dem See des Wahnsinns Schlittschuh laufe.
[Hanns Mattes in dovecot-de]




More information about the AppArmor mailing list