[apparmor] [patch] Hand over CFLAGS when compiling parser/libapparmor_re/

[John Johansen]

On 07/28/2015 12:44 PM, Christian Boltz wrote:
> Hello,
> 
> Am Freitag, 17. Juli 2015 schrieb Christian Boltz:
>> when compiling for openSUSE, the build checks warn about:
>>
>> I: File is compiled without RPM_OPT_FLAGS
>> W: apparmor no-rpm-opt-flags <cmdline>:parser_common.c,
>> parser_include.c, parser_interface.c, parser_lex.c, parser_main.c,
>> parser_misc.c, parser_merge.c, parser_symtab.c, parser_yacc.c,
>> parser_regex.c, parser_variable.c, parser_policy.c, parser_alias.c,
>> common_optarg.c, lib.c, network.c, mount.cc, dbus.cc, profile.cc,
>> rule.cc, signal.cc, ptrace.cc, af_rule.cc, af_unix.cc, policy_cache.c,
>> parse.cc, expr-tree.cc, hfa.cc, chfa.cc, aare_rules.cc
>>
>> While searching for the reason, I noticed that parser/libapparmor_re/
>> gets CFLAGS overwritten with EXTRA_CXXFLAGS, instead of appending
>> them.
> 
> as already mentioned on IRC:
> On a second look, the definition of EXTRA_CXXFLAGS includes CFLAGS (how 
> could I overlook that?), so actually CFLAGS isn't overwritten. This also 
> means this patch is superfluous.
> 
> Nevertheless, there's still something that overrides or ignores 
> RPM_OPT_FLAGS, but I have no idea what it is.
> 
Well I would say because our Makefile is pretty borked :)

It isn't handling CXXFLAGS which is the normal set of flags for C++ which
we have switched to.