[apparmor] [patch] Hand over CFLAGS when compiling parser/libapparmor_re/

Christian Boltz apparmor at cboltz.de
Fri Jul 17 20:33:19 UTC 2015


Hello,

when compiling for openSUSE, the build checks warn about:

I: File is compiled without RPM_OPT_FLAGS
W: apparmor no-rpm-opt-flags <cmdline>:parser_common.c, 
parser_include.c, parser_interface.c, parser_lex.c, parser_main.c, 
parser_misc.c, parser_merge.c, parser_symtab.c, parser_yacc.c, 
parser_regex.c, parser_variable.c, parser_policy.c, parser_alias.c, 
common_optarg.c, lib.c, network.c, mount.cc, dbus.cc, profile.cc, 
rule.cc, signal.cc, ptrace.cc, af_rule.cc, af_unix.cc, policy_cache.c, 
parse.cc, expr-tree.cc, hfa.cc, chfa.cc, aare_rules.cc

While searching for the reason, I noticed that parser/libapparmor_re/
gets CFLAGS overwritten with EXTRA_CXXFLAGS, instead of appending them.

Note: With this patch applied, the build still works, but it also still
results in the same warning, so there must be another place breaking
CFLAGS.

As usual, let me also add the warning that I don't really know what I'm
doing when it comes to C code ;-)



[ parser-cflags.diff ]

=== modified file 'parser/Makefile'
--- parser/Makefile     2015-06-24 23:18:04 +0000
+++ parser/Makefile     2015-07-16 22:31:59 +0000
@@ -302,7 +302,7 @@
 .SILENT: $(AAREOBJECT)
 .PHONY: $(AAREOBJECT)
 $(AAREOBJECT):
-       $(MAKE) -C $(AAREDIR) CFLAGS="$(EXTRA_CXXFLAGS)"
+       $(MAKE) -C $(AAREDIR) CFLAGS="$(CFLAGS) $(EXTRA_CXXFLAGS)"
 
 .PHONY: install-rhel4
 install-rhel4: install-redhat




Regards,

Christian Boltz
-- 
> You cannot mix selections and patterns in a product - and we
> will remove all selection support now.
AAARRRRRRGGGGGG. Needing to re-write makeSUSEdvd again. ;-)
It looks like you do all this on purpose, just to anoy me. :-D
[> Andreas Jaeger and houghi in opensuse]




More information about the AppArmor mailing list