[apparmor] [patch] drop shebang from apparmor/rule/*.py

Tyler Hicks tyhicks at canonical.com
Fri Jul 17 18:59:12 UTC 2015


On 2015-07-17 00:47:23, Christian Boltz wrote:
> Hello,
> 
> Am Donnerstag, 16. Juli 2015 schrieb Tyler Hicks:
> > On 2015-07-17 00:19:51, Christian Boltz wrote:
> > > the '#!/usr/bin/env python' line in apparmor/rule/*.py is
> > > superfluous
> > > and causes "non-executable script" rpmlint warnings on openSUSE.
> > 
> > Is it more correct to leave the shebang and make the files executable?
> 
> No, it doesn't make sense to make python modules executable.
> (Executing them does nothing [1], and if it would do something, they'd 
> be called "scripts" and live in /usr/bin/ or /usr/sbin/ ;-)
> 
> If you prefer a popular vote: all python modules in 
> /usr/lib/python3.4/site-packages are -rw-r--r-- on openSUSE ;-)

For some reason I thought these were test scripts when I glanced at the
patch yesterday. Your approach is obviously correct for modules.

Acked-by: Tyler Hicks <tyhicks at canonical.com>

Tyler

> 
> 
> Regards,
> 
> Christian Boltz
> 
> [1] well, technically "nothing" is not correct - python reads the code
>     so that the *Rule and *Ruleset classes could be used - but the 
>     modules end without doing that, which means executing the module
>     means wasting some CPU cycles ;-)
> -- 
> > [submit-request #65647 declined by saschpe:]
> >   description is >400 lines, too long :-)
> Where is a limit documented?
> [Stephan Kulow in opensuse-packaging]
> 
> 
> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150717/d599bb34/attachment.pgp>


More information about the AppArmor mailing list