[apparmor] [patch] Ignore file_perm events without request_mask

Steve Beattie steve at nxnw.org
Wed Jul 8 13:35:50 UTC 2015

On Tue, Jul 07, 2015 at 09:34:16PM +0200, Christian Boltz wrote:
> I'd prefer another way, but that is a bigger change, so I'll probably
> delay it after the 2.10 release ;-)
> Currently it's very hard to write tests for add_event_to_tree() because
> the last thing it does is self.add_to_tree(parsed_event). My plan is to 
> change that to return() the event, and then let the caller (or a small 
> function in the middle?) calls self.add_to_tree(). This will make 
> testing much easier because we can simply check the return value.

I like the sound of this plan.

> Therefore I just changed the patch to return None to be consistent.


> Updated patch:
> [ 54-logparser-fileperm-without-request_mask-lp1466812.diff ]

Acked-by: Steve Beattie <steve at nxnw.org> for trunk and 2.9, thanks.

Steve Beattie
<sbeattie at ubuntu.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150708/0d1570a3/attachment.pgp>

More information about the AppArmor mailing list