[apparmor] [PATCH] add --set-env option to aa-sandbox and move os.chdir()

[Christian Boltz]

Hello,

Am Donnerstag, 6. Februar 2014 schrieb Christian Boltz:
> Am Donnerstag, 6. Februar 2014 schrieb Jamie Strandboge:
> > = aa-sandbox_add_set-env_option.patch =
> > 
> > +    for e in opt.setenv_vars:
> > +        if '=' not in e:
> > +            continue
> 
> if broken:
>     ignore_silently()
> 
> ;-)
> 
> Seriously: if someone calls aa-sandbox with an invalid parameter
> (that's what a missing "=..." is), there should _at least_ be a
> warning. I'd even vote to abort with an error message - that's better
> than running with unexpected / not-overwritten env variables)
> 
> And as Steve already noticed, the print looks superfluous.

It seems this patch was never commited :-(  - did this (not) happen for 
a good reason, or did you just forget it?

Before commiting,
- Can you please adjust it to error out on an invalid parameter?
- Also, don't forget to add the same code to run_sandbox() (as pointed 
  out by Steve) or, better, make it a little function that can be used 
  in both places ;-)


Regards,

Christian Boltz
-- 
So ihr habt euch jetzt garantiert totgelacht, die Schenkel
blutig gehauen oder sämtliche Tischkanten zerbissen  [...]
[Edgar (Ede) Kuchelmeister in suse-linux]