[apparmor] [PATCH 20/31] parser: Remove prints and exits from features code

[Steve Beattie]

On Fri, Feb 27, 2015 at 10:18:08AM -0800, John Johansen wrote:
> On 02/27/2015 09:11 AM, Tyler Hicks wrote:
> > On 2015-02-27 11:08:28, Tyler Hicks wrote:
> >> I wanted to give you a quick update on what my plans are here. The code
> >> that is being moved from the parser to libapparmor has calls to PERROR()
> >> and PDEBUG(). Here's my thoughts on how to handle them in libapparmor:
> >>
> >>
> >>  * PDEBUG()
> >>    - Compiled out unless libapparmor is built with --enable-debug
> >>    - Prints to stderr if libapparmor is built with --enable-debug and
> >>      the LIBAPPARMOR_DEBUG environment variable is set
> > 
> > One correction. To match the current PDEBUG() implementation in the
> > parser, the libapparmor PDEBUG() would need to print to stdout instead
> > of stderr.
> > 
> stderr is the correct place, I am not sure why thate parser currently uses
> stdout

I concur, that it currently emits debugging info to stdout instead
of stderr is probably a bug.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150227/e0149638/attachment.pgp>