[apparmor] [patch] Fix a test name in test-signal.py

Tyler Hicks tyhicks at canonical.com
Thu Dec 17 16:38:14 UTC 2015


On 2015-12-04 21:29:18, Christian Boltz wrote:
> Hello,
> 
> $subject.
> 

  Acked-by: Tyler Hicks <tyhicks at canonical.com>


Side question, how come these patches don't include a Signed-off-by? The
idea behind code provenance (tracking who wrote a patch, who acked it,
etc.) is that the author includes a "Developer's Certificate of Origin"
by including an S-o-b:

  https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n409

It really isn't a big deal to me but it seems like something that all
committers should be doing or that none of us should be doing. If you
don't want to include an S-o-b, then lets define the process. If you
don't mind, then that's even better. :)

Tyler

> 
> [ 26-test-signal-better-test-name.diff ]
> 
> === modified file ./utils/test/test-signal.py
> --- utils/test/test-signal.py   2015-12-04 17:57:08.557599671 +0100
> +++ utils/test/test-signal.py   2015-11-19 17:46:14.472311782 +0100
> @@ -88,7 +88,7 @@
>              SignalRule.parse(rawrule)
>  
>  class SignalTestParseFromLog(SignalTest):
> -    def test_net_from_log(self):
> +    def test_signal_from_log(self):
>          parser = ReadLog('', '', '', '', '')
>          event = 'type=AVC msg=audit(1409438250.564:201): apparmor="DENIED" operation="signal" profile="/usr/bin/pulseaudio" pid=2531 comm="pulseaudio" requested_mask="send" denied_mask="send" signal=term peer="/usr/bin/pulseaudio///usr/lib/pulseaudio/pulse/gconf-helper"'
>  
> 
> 
> 
> Regards,
> 
> Christian Boltz
> -- 
> "Golden rule of Sourcecode: 50% are comments, and the other 50% bugs!"
> 
> 
> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20151217/60a395a6/attachment.pgp>


More information about the AppArmor mailing list