[apparmor] How I found several bugs in less than an hour - without even searching for them

[Steve Beattie]

On Sun, Jul 12, 2015 at 04:00:15PM +0200, Christian Boltz wrote:
> Am Donnerstag, 9. Juli 2015 schrieb Christian Boltz:
> > Here's the updated patch:
> 
> Allowing variables in profile names brought some new failures, most of 
> them not raised exceptions, so here's v3.
> 
> I also removed rlimits/test1.sd from the list of failing tests - that's
> a file I only had locally.

I'm currently in a situation where I don't have easy accesss to my
regular environment, but I'm getting failures when running the tests
with python2, like so:

======================================================================
 ERROR: test_44306 (__main__.TestParseParserTests) test '{'exresult': u'PASS', 'tools_wrong': False, 'relfile': 'rlimits/ok_rlimit_01.sd', 'disabled': False, 'file': '/home/steve/bzr/apparmor/parser/tst/simple_tests/rlimits/ok_rlimit_01.sd', 'todo': False}'
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/steve/bzr/apparmor/utils/test/common_test.py", line 103, in stub_test
    self._run_test(test_data, expected)
  File "test-parser-simple-tests.py", line 344, in _run_test
    apparmor.parse_profile_data(data, params['file'], 0)
  File "/home/steve/bzr/apparmor/utils/apparmor/aa.py", line 2690, in parse_profile_data
    profile_data[profile][hat]['rlimit'].add(RlimitRule.parse(line))
  File "/home/steve/bzr/apparmor/utils/apparmor/rule/__init__.py", line 73, in parse
    rule = cls._parse(raw_rule)
  File "/home/steve/bzr/apparmor/utils/apparmor/rule/rlimit.py", line 135, in _parse
    comment=comment)
  File "/home/steve/bzr/apparmor/utils/apparmor/rule/rlimit.py", line 66, in __init__
    raise AppArmorBug('Passed unknown object to RlimitRule: %s' % str(rlimit))
AppArmorBug: Passed unknown object to RlimitRule: cpu

----------------------------------------------------------------------

I don't *think* it's due to a quirk in my setup. With python3, it passes
all tests.

(Granted, I would like to deprecate python2 in 2.11, making python3
preferred, and then drop python2 support in 2.11+1.)

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150813/5b239aae/attachment.pgp>