[apparmor] [patch] simplify serialize_parse_profile_start()

Steve Beattie steve at nxnw.org
Fri Apr 3 08:50:46 UTC 2015


On Thu, Mar 19, 2015 at 09:47:34PM +0100, Christian Boltz wrote:
> this patch changes serialize_parse_profile_start() to use 
> parse_profile_start() instead of using duplicated code.
> 
> The behaviour is mostly kept, with the exception that the function is 
> more strict now and raises exceptions instead of ignoring errors.
> 
> In practise, this won't change anything because the profiles are parsed
> with parse_profile() (which calls parse_profile_start()) - and that 
> already errors out.
> 
> The tests are updated to match the more strict behaviour.
> 
> 
> The next step would be to drop serialize_parse_profile_start() 
> completely, but this isn't urgent and can/should be done when we have 
> test coverage for serialize_profile_from_old_profile() one day ;-)
> 
> As usual, this patch is for trunk and 2.9.
> 
> 
> [ 27-simplify-serialize_parse_profile_data.diff ]

Acked-by: Steve Beattie <steve at nxnw.org> for trunk. Thanks.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150403/fa492836/attachment.pgp>


More information about the AppArmor mailing list