[apparmor] [patch] fix is_skippable_dir() and add tests

[Steve Beattie]

On Thu, Mar 19, 2015 at 09:10:05PM +0100, Christian Boltz wrote:
> this patch fixes is_skippable_dir() - the regex also matched things like
> /etc/apparmor.d/dont_disable, while it should match on the full 
> directory name.
> 
> Also add some tests based on a real-world aa-logprof run (with "print (path)"
> in is_skippable_dir()) and some additional "funny"[tm] dirs.
> 
> Needless to say that the tests
>         ('dont_disable',                False),
>         ('/etc/apparmor.d/cache_foo',   False),
> will fail with the old is_skippable_dir().
> 
> I propose this patch for trunk and 2.9.
> [ 26-fix-is_skippable_dir.diff ]

Acked-by: Steve Beattie <steve at nxnw.org> for trunk. The actual fix in
utils/apparmor/aa.py is fine for 2.9, but we (I?) haven't decided on
pulling the AATest stuff to 2.9, so it wouldn't be acceptable in
isolation unless some reworking occurred.

Thanks.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150403/c1c01191/attachment.pgp>