[apparmor] [patch] Finally implement attachment handling

[Steve Beattie]

On Thu, Apr 02, 2015 at 12:05:45PM +0200, Christian Boltz wrote:
> Hello,
> 
> Am Sonntag, 15. März 2015 schrieb Christian Boltz:
> > Am Sonntag, 15. März 2015 schrieb Christian Boltz:
> > > and finally...
> > >
> > > *drumroll*
> > >
> > > This patch implements attachment handling - aa-logprof now works
> > > with
> > > profiles that have an attachment defined, instead of ignoring
> > > audit.log entries for those profiles.
> > >
> > > 
> > >
> > > Changes:
> > > - parse_profile_start_line(): remove workaround that merged the
> > >
> > >   attachment into the profile name
> > >
> > > - parse_profile_data(): store attachment when parsing a profile
> > > - update test_parse_profile_start_03,
> > > test_serialize_parse_profile_start_03 and some
> > > parse_profile_start_line() tests - they now expect correct
> > > attachment
> > > handling
> > >
> > > 
> > >
> > > Note: this patch is not fully covered by tests.
> > > I manually tested aa-logprof with some profiles with and without
> > > attachment, and it works for both.
> > >
> > > 
> > >
> > > As usual, I propose this patch for trunk and 2.9 (I do that for all 
> > > patches in this series, even if I forgot to mention it in some
> > > patches ;-)
> > 
> > Here's v2 - the only change is an update to
> > test_set_flags_nochange_09() which I missed before.
> 
> After the whitespace changes in patch 20, this patch failed to apply.
> Here's v3 that adopts to the whitespace changes in test-regex_matches.py
> 
> 
> [ 22-handle-profiles-with-attachment.diff ]
> 

Acked-by: Steve Beattie <steve at nxnw.org>. Thanks!

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20150403/be5f3139/attachment.pgp>