[apparmor] [Patch][parser]

[Steve Beattie]

On Sun, Sep 21, 2014 at 12:15:51AM -0700, John Johansen wrote:
> On 09/20/2014 11:52 AM, Christian Boltz wrote:
> > Hello,
> > 
> v2 of the patch returning the last error encountered
> 
> fix: Make the parser behave the same as when driven with xargs -n1
> 
> Currently the parser is bailing when it fails to load a profile,
> not processing any potential subsequent profiles in the dir or passed
> in list. This results in all policy after the first error failing
> to load, instead of just the profile(s) with the error.
> 
> This is a different behavior than what has been done by initscripts
> that have driven it with xargs -n1, passing it a single profile
> at a time.
> 
> Fix this so that the parser only exits on first error if specifically
> told to do so.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>

Acked-by: Steve Beattie <steve at nxnw.org>, thanks.

> Note: this does not fix the various failure points in the parser
> that call exit, instead of returning an error.

Yep, a *lot* of work to do there to clean that up, in particular to make
sure we don't leak memory.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140922/2041767b/attachment.pgp>