[apparmor] [pkg-apparmor] Bug#761733: apparmor: libtool split

[Steve Beattie]

The follwoing bug report was filed in Debian against apparmor:

On Mon, Sep 15, 2014 at 11:41:18PM +0000, Matthias Klose wrote:
> Package: src:apparmor
> Version: 2.8.0-5.1
> Severity: wishlist
> User: debian-cross at lists.debian.org
> Usertags: libtool-split
> 
> As part of the effort to cross-build the archive, the libtool package
> needs a split into an architecture independent part and an
> architecture dpendent part (the latter only consisting of the libtool
> binary).  The split is already done for jessie/sid, but to enable the
> cross buildability, the dependency in libtool on libtool-bin needs to
> be removed, and libtool-bin needs to depend on libtool instead.
> 
> The vast majority of packages using libtool via automake don't need
> the libtool binary, and thus no changes in the build dependencies, however
> about 60 source packages are using libtool directly, and need changes.
> 
>  - some packages just check for the libtool binary, and then don't
>    use it for the build (but are using libtoolize instead).  Such
>    usages are seen in a script called buildcheck.sh, and sometimes
>    in autogen.sh scripts.  The solution for these cases is to patch
>    these scripts to check for libtoolize instead of libtool, and
>    not to introduce the new build dependency.

This was the case for apparmor, checking for libtool, but actually using
libtoolize in the build. This was fixed in lp:apparmor commit 2295, and
I'm nominating it for the 2.8 branch.

libapparmor: require libtoolize instead of libtool
Merge from trunk commit 2295.

libtoolize is the standard mechanism for incorporating libtool support
into a library; however, libapparmor's autogen.sh script specifically
looks for the existence of the libtool binary rather than libtoolize.
The libtoolize tool automatically generates a libtool script and does
not require the existence of the libtool binary, so we no longer need
to check for it.

The autogen.sh script aborting because it can't find the libtool
binary causes a spurious build failure in Ubuntu 14.04, due to the
libtool binary being separated out into its own package, and which
is not a strict dependency for libtool.

(I also added setting the package variable so that the error message
emitted will indicate that the failure is in building libapparmor.)

Nominated-by: Steve Beattie <steve at nxnw.org>

=== modified file 'libraries/libapparmor/autogen.sh'
--- libraries/libapparmor/autogen.sh	2013-12-02 22:49:08 +0000
+++ libraries/libapparmor/autogen.sh	2014-01-03 23:13:26 +0000
@@ -1,6 +1,7 @@
 #!/bin/sh
 
 DIE=0
+package=libapparmor
 
 (autoconf --version) < /dev/null > /dev/null 2>&1 || {
         echo
@@ -19,7 +20,7 @@
         DIE=1
 }
 
-(libtool --version) < /dev/null > /dev/null 2>&1 || {
+(libtoolize --version) < /dev/null > /dev/null 2>&1 || {
 	echo
 	echo "You must have libtool installed to compile $package."
 	echo "Download the appropriate package for your system,"


-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140916/2fe1fe0d/attachment.pgp>