[apparmor] [patch] [utils] Fix unnamed arguments in messages for translatable string
Kshitij Gupta
kgupta8592 at gmail.com
Sun Sep 14 14:25:57 UTC 2014
Hello,
The translatable strings used unnamed arguments which generated a
number of warnings, as noted by @sbeattie in a previous patch.
This patch:
- replaces unnamed arguments with named arguments wherever more than 1
one arguments ware present in a message
- minor fix in aa-unconfined for pname argument in 2 strings
- updated pot files (as a side-effect of testing with make)
PS:
Testing with make file I found two things:
1. running make check fails saying it doesn't recognise raw_input()
apparmor/ui.py:179: undefined name 'raw_input'
I think pyflakes is being run for Python3 and hence the error. Is
there any easy way to make this work?
2. I also get a curious second trace,
make[1]: Entering directory
`/home/kshitij/workspace/apparmor-workspace/4patch/original/apparmor/utils/test'
Makefile:21: common/Make.rules: No such file or directory
ln -sf ../../common/ .
make[1]: Leaving directory
`/home/kshitij/workspace/apparmor-workspace/4patch/original/apparmor/utils/test'
make[1]: Entering directory
`/home/kshitij/workspace/apparmor-workspace/4patch/original/apparmor/utils/test'
Traceback (most recent call last):
File "test-pivot_root_parse.py", line 12, in <module>
import apparmor.aa as aa
File "/home/kshitij/workspace/apparmor-workspace/4patch/original/apparmor/utils/apparmor/aa.py",
line 29, in <module>
import apparmor.logparser
File "/home/kshitij/workspace/apparmor-workspace/4patch/original/apparmor/utils/apparmor/logparser.py",
line 18, in <module>
import LibAppArmor
ImportError: No module named LibAppArmor
make[1]: *** [check] Error 1
make[1]: Leaving directory
`/home/kshitij/workspace/apparmor-workspace/4patch/original/apparmor/utils/test'
make: *** [check] Error 2
I dont know enough about make files to debug it. (I feel it has
something to do with Python2 not having the module)
Regards,
Kshitij Gupta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gettext.patch
Type: text/x-patch
Size: 35365 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140914/99e92b7a/attachment-0001.bin>
More information about the AppArmor
mailing list