[apparmor] Fwd: Bug#760378: apparmor: FTBFS on x32 due to use of sysctl

[Seth Arnold]

On Tue, Sep 09, 2014 at 04:41:16PM -0700, intrigeri wrote:
> Hi,
> 
> may someone please have a look at https://bugs.debian.org/760378,
> that was filed as part of the x32 architecture bootstrapping effort,
> and might very well be highlighting a more general problem?
> 
> 

Thanks for forwarding this along; the #include <sys/sysctl.h> dates from
the ancient times, probably Linux 2.0 or 2.2 days.

The attached patch removes the header unconditionally; the parser builds
and passes "make check USE_SYSTEM=1" on my Ubuntu 14.04 LTS laptop.

I propose this patch for trunk:

Signed-off-by: Seth Arnold <seth.arnold at canonical.com>

=== modified file 'parser/parser_main.c'
--- parser/parser_main.c	2014-09-03 20:22:26 +0000
+++ parser/parser_main.c	2014-09-10 03:06:44 +0000
@@ -35,7 +35,6 @@
 
 #include <unistd.h>
 #include <limits.h>
-#include <sys/sysctl.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/apparmor.h>


Thanks

> Date: Thu, 04 Sep 2014 20:11:11 -0700
> From: Daniel Schepler <dschepler at gmail.com>
> To: Thorsten Glaser <tg at mirbsd.de>, 760378 at bugs.debian.org
> Subject: Bug#760378: apparmor: FTBFS on x32 due to use of sysctl
> User-Agent: KMail/4.14 (Linux/3.14-2-amd64; KDE/4.14.0; x86_64; ; )
> 
> On Wednesday, September 03, 2014 02:27:42 PM Thorsten Glaser wrote:
> > the attached patch makes apparmor build on x32.
> > I did not see how I could use autoconf for this,
> > so the architecture check is currently hardcoded,
> > and will likely have to be extended e.g. by arm64
> > later.
> 
> It would probably be a better idea to remove the sysctl(2) code altogether, as 
> the kernel support is unmaintained anyway, and as I understand it, the kernel 
> complains to the dmesg log if sysctl is ever actually called.
> -- 
> Daniel Schepler
> 

> 
> 
> -- 
> intrigeri

> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140909/9161df99/attachment.pgp>