[apparmor] [patch 0/3] libapparmor: a few aalogparse fixes

[Steve Beattie]

On Wed, Sep 03, 2014 at 05:09:14PM -0700, Seth Arnold wrote:
> On Wed, Sep 03, 2014 at 12:40:20AM -0700, Steve Beattie wrote:
> > In preparation for adding support for the new af_unix abstract socket
> > log messages, the following patch series addresses some currently
> > existing bugs in libapprmor's aalogparse functionality.
> > 
> > I have an un-included patch that adjusts the SO version, but want
> > to wait to get closer to a release before submitting/applying it,
> > so that we don't gratuitously change the version numbers.
> > 
> > Discovering log messages that libapparmor does not parse was done via
> > the included python script. I intend to submit it for inclusion, but I
> > need to modify it to return an error code if it finds messages it can't
> > parse, to allow it to be used as one of the last steps of test runs.
> > It's also unclear to me where in the source tree to make it available,
> > since it's clearly a developer oriented tool. Suggestions welcome.
> 
> I like this script, it shows an easy use of the record parsing API. This
> deserves wider distribution even if only as an example.

I was contemplating either under tests/regression somewhere, or in
a utils/devel/ directory that could have other apparmor developer
oriented utilities. I don't think the tool is generally useful enough to
get installed into /usr/bin.

> One funny piece is the fileinput.input() used in addition to the
> for f in config.logfile:  loop. One or the other could go.

Yeah, fair enough. I haven't used fileinput.input() before and I wasn't
sure whether/how things would be interleaved between multiple log files.
I think using fileinput would be good for the utils so that it can
handle multiple log files better (I can't remember if it handles
multiple files at all).

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140904/60654520/attachment.pgp>