[apparmor] [patch 13/12] v3 unix socket rules

Steve Beattie steve at nxnw.org
Wed Sep 3 22:56:44 UTC 2014


On Fri, Aug 29, 2014 at 12:40:37PM -0700, John Johansen wrote:
> This changes/fixes the encoding for unix socket rules.
> 
> the changes look larger than they are because it refactors the code, instead
> of duplicating.
> 
> The major changes are:
> - it changes where the accept perm is stored
> - it moves anyone_match_pattern to default_match_pattern
> - it fixes the layout of the local addr only being written when local perms
>   are present
> 
> ---
> 
> === modified file 'parser/af_unix.cc'
> --- parser/af_unix.cc	2014-08-27 21:38:24 +0000
> +++ parser/af_unix.cc	2014-08-29 19:33:32 +0000
> @@ -226,13 +226,99 @@
>  		((mask & (AA_NET_SETOPT | AA_NET_GETOPT)) >> 5); /* 5 + (AA_OTHER_SHIFT - 24) */
>  }
>  
> +void unix_rule::write_to_prot(std::ostringstream &buffer)

I would probably name this method write_protocol (or write_proto), but
otherwise: Acked-by: Steve Beattie <steve at nxnw.org>.

Thanks.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140903/ead4e991/attachment.pgp>


More information about the AppArmor mailing list