[apparmor] [patch] tests: mark failing dgram tests in unix_socket_pathname.sh as xpass

Steve Beattie steve at nxnw.org
Thu Oct 9 01:57:09 UTC 2014


tests: mark failing dgram tests in unix_socket_pathname.sh as xpass

With the addition of the unix socket mediation and
corresponding tests, there are currently two tests that fail
in unix_socket_pathname.sh. These have been recorded as bugs
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1373174 and
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1373176 but John
has not had time to investigate if these are legitimate bugs. The
following patch marks the tests as expecting to pass but currently
failing.

Signed-off-by: Steve Beattie <steve at nxnw.org>
---
 tests/regression/apparmor/unix_socket_pathname.sh |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Index: b/tests/regression/apparmor/unix_socket_pathname.sh
===================================================================
--- a/tests/regression/apparmor/unix_socket_pathname.sh
+++ b/tests/regression/apparmor/unix_socket_pathname.sh
@@ -80,6 +80,16 @@ testsocktype()
 	local af_unix
 	local af_unix_access
 
+	# Adjust this when
+	#   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1373174
+	# and
+	#   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1373174
+	# get resolved
+	local ex_result="pass"
+	if [ "${socktype}" == "dgram" ] ; then
+		ex_result="xpass"
+	fi
+
 	removesockets $sockpath $client_sockpath
 
 	# PASS - unconfined
@@ -94,7 +104,7 @@ testsocktype()
 	# PASS - server w/ access to the file
 
 	genprofile $sockpath:$okserver $af_unix $client:Ux
-	runchecktest "$testdesc; confined server w/ access ($okserver)" pass $args
+	runchecktest "$testdesc; confined server w/ access ($okserver)" $ex_result $args
 	removesockets $sockpath $client_sockpath
 
 	# FAIL - server w/o access to the file
@@ -152,7 +162,7 @@ testsocktype()
 	# PASS - client w/ access to the file
 
 	genprofile $server -- image=$client $sockpath:$okclient $af_unix
-	runchecktest "$testdesc; confined client w/ access ($okclient)" pass $args
+	runchecktest "$testdesc; confined client w/ access ($okclient)" $ex_result $args
 	removesockets $sockpath $client_sockpath
 
 	# FAIL - client w/o access to the file

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20141008/06fa38bf/attachment.pgp>


More information about the AppArmor mailing list