[apparmor] [patch] aa.py: use named match groups for capability
Christian Boltz
apparmor at cboltz.de
Wed Oct 1 19:45:06 UTC 2014
Hello,
Am Mittwoch, 1. Oktober 2014 schrieb Steve Beattie:
> On Fri, Sep 26, 2014 at 10:00:33PM +0200, Christian Boltz wrote:
> > Feel free to comment about named match groups and the other changes
> > introduced with this patch in general. Capability is the
> > "prototype",
> > similar patches for other rule types will follow sooner or later.
> > (I won't complain if someone "grabs" one of the rule types so that I
> > don't have to do everything ;-)
>
> Given how complex the regular expressions we use are, named match
> groups I think are a needed improvement, which is my way of saying
> that I like the direction.
:-)
> I'm assuming the patch was pasted into KMail, as it had some problems
> applying locally due to a mis-formatting error:
Yes, KMail can do funny things with whitespace - but there was also a
line that really had superfluous whitespace in aa.py. I fixed that
before commiting.
Regards,
Christian Boltz
--
<cboltz> jjohansen: you are making it too easy for kshitij8 ;-)
<jjohansen> cboltz: oops sorry, now I'll have to come up with a new task
to make him suffer :)
<sarnold> review the c++11 conversion? :)
* sarnold runs
<jjohansen> haha, sarnold I said suffer, not drive him to commit suicide
[from #apparmor]
More information about the AppArmor
mailing list