[apparmor] [PATCH 6/6] Update the top-level README for the utils rewrite

[Tyler Hicks]

On 2014-11-18 00:56:31, Christian Boltz wrote:
> Hello,
> 
> Am Montag, 17. November 2014 schrieb Tyler Hicks:
> > Modify the build instructions and project requirements to reflect the
> > utils rewrite from Perl to Python.
> 
> > --- a/README
> > +++ b/README
> > @@ -62,13 +62,13 @@ the following order.
> >  libapparmor:
> >  $ cd ./libraries/libapparmor
> >  $ sh ./autogen.sh
> > -$ sh ./configure --prefix=/usr --with-perl	# see below
> > +$ sh ./configure --prefix=/usr --with-python	# see below
> >  $ make
> >  $ make check
> >  $ make install
> > 
> > -[optional arguments to libapparmor's configure include --with-python
> > - and --with-ruby, to generate python and ruby bindings to
> > libapparmor, +[optional arguments to libapparmor's configure include
> > --with-perl + and --with-ruby, to generate Perl and Ruby bindings to
> > libapparmor, respectively.]
> 
> I just had a look at the utils directory, and we still have some tools 
> that use perl:
> - aa-exec and aa-notify [1] have "require LibAppArmor;" - so we still
>   need the perl bindings. This means README should recommend
>       --with-perl --with-python
> - aa-decode uses some inline perl
> - check_po.pl is also perl, but it seems it's not used at all. Reading 
>   the description comment in it, it might be a good idea to integrate it 
>   in "make check". OTOH, after giving it a short test, I think we need 
>   to fix it first ;-)

Agreed. Thanks for checking.

> 
> > @@ -207,9 +204,7 @@ The AppArmor userspace utilities are written with
> > some assumptions about installed and available versions of other
> > tools. This is a (possibly incomplete) list of known version
> > dependencies:
> > 
> > -AppArmor.pm (used by aa-audit, aa-autodep, aa-complain, aa-disable,
> > -aa-enforce, aa-genprof, aa-logprof, aa-unconfined) requires minimum
> > -Perl 5.10.1.
> 
> Please keep a note that some tools require perl. I'm not sure if the 
> version note is needed - OTOH, 5.10.1 is quite old, so I'd be surprised 
> to find anything older out there ;-)

The section is titled "Required version" so I'll leave the version in
there.

> 
> > +The Python utilities require a minimum of Python 2.7 or Python 3.3.
> > 
> >  Python scripts require a minimum of Python 2.7. Some utilities as
> > well as some of the parser test scripts may require Python 3.3.
> > Python 3.0,
> 
> That means we have two python version notes now - is this intentional?

Nope.

v2 will follow...

Tyler

> 
> 
> Regards,
> 
> Christian Boltz
> 
> [1] aa-notify probably needs a rewrite from scratch (and maybe a split 
>     into a) desktop notifications and b) log summary), but that's 
>     another story ;-)
> 
> -- 
> Entwickler sollten nicht danach bezahlt werden, wie viel Code 
> sie schreiben, sondern wie viel Code sie wegschmeißen.
> [Robert Lemke, http://heise.de/-1362225]
> 
> 
> -- 
> AppArmor mailing list
> AppArmor at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20141117/19e7e89e/attachment.pgp>