[apparmor] [patch] utils: make test-severity pyflakes compliant
Christian Boltz
apparmor at cboltz.de
Thu Nov 13 17:19:57 UTC 2014
Hello,
Am Mittwoch, 12. November 2014 schrieb Steve Beattie:
> Speaking of recent commits that broke 'make check' in the utils/ tree,
> the recent re-work of the severity.db tests were not verified to be
> pyflakes clean (bad Steve, no donut). All but one of pyflakes
To save that donut from rotting, just send it to me ;-)
That said - we have "make check" and "make test". Maybe we should merge
them into one target so that one command will check everything.
Hmm, maybe using
test: check
in the Makefile would already improve the situation.
> complaints are of marginal impact (assigning to a variable that isn't
> later referenced); however, one legitimate issue it detected is that
> I'd inadvertently created two test cases with the same method name,
> so only one test case would actually be used.
That's the problem with copy&paste-programming ;-)
> The following patch fixes the issues.
>
> Signed-off-by: Steve Beattie <steve at nxnw.org>
Acked-by: Christian Boltz <apparmor at cboltz.de>
Regards,
Christian Boltz
--
> Ist doch laut Deinen Schilderungen von den Hardwareanforderungen her
> eine perfekte Konkurrenz zu Vista *renn* ;-)
Da hast du recht ! Aber warum rennen :-) es wird dir kaum jemand
hinterherlaufen weil alle vor der Kiste sitzen um auf die Katalogupdates
zu warten ... [> Benjamin Zeller und Helmut Zengerling in suse-linux]
More information about the AppArmor
mailing list