[apparmor] [patch] utils: remove aa-disable non-functional '-r' option

Steve Beattie steve at nxnw.org
Mon Mar 3 16:33:50 UTC 2014

On Fri, Feb 28, 2014 at 09:34:51PM +0100, Christian Boltz wrote:
> Am Montag, 24. Februar 2014 schrieb Steve Beattie:
> > I should note that one side effect is that this patch effectively
> > neuters the -r (revert) option for aa-disable. I don't really like
> > that option (I'd rather point people at using aa-enforce to undo
> > aa-disable). I can submit a patch that either removes the option or
> > adds the functionality if we desire it.
> The -r option was probably inspired by the -r option of aa-complain and 
> aa-audit, but I understand your POV that it might be confusing in a 
> triple-state case (enforce/complain/disabled).
> Anyway, either remove the -r option or make sure it's working ;-)

Here's the patch to remove the -r option for aa-disable, as well as the
test and manpage documentation for it. Thanks!

Steve Beattie
<sbeattie at ubuntu.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: utils-remove_aa-disable_revert_option.patch
Type: text/x-diff
Size: 2598 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140303/68558f8e/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140303/68558f8e/attachment.pgp>

More information about the AppArmor mailing list