[apparmor] [patch] fix log parsing memory leaks

Steve Beattie steve at nxnw.org
Fri Jul 11 22:57:57 UTC 2014

On Fri, Jul 11, 2014 at 03:35:32PM -0700, Seth Arnold wrote:
> On Fri, Jul 11, 2014 at 03:24:29PM -0700, Steve Beattie wrote:
> > This patch fixes some memory leaks in the libapparmor log parsing functions,
> > specifically around handling records obtained from syslog and records
> > containing network addresses.
> > 
> > Bug: https://bugs.launchpad.net/bugs/1340927
> > Signed-off-by: Steve Beattie <steve at nxnw.org>
> Wow, nice catch and fast debugging.

Valgrind and existing test cases are a heck of a thing.

Would be nice to hook up an automated target that integrates valgrind
into libapparmor's make check, at least optionally. Also, generating
coverage information would be useful, too.

Even with this fix, there are a few testcases that valgrind reports
leaks; they're specifically cases that are invalid parse records. I
have not tracked down exactly what's going wrong there.

Steve Beattie
<sbeattie at ubuntu.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140711/ce8cf89a/attachment-0001.pgp>

More information about the AppArmor mailing list