[apparmor] [patch 2/3] parser: Add make variable to build against local or system libapparmor [v2]

[Steve Beattie]

On Mon, Jan 06, 2014 at 02:29:36PM -0600, Tyler Hicks wrote:
> On 2013-12-24 12:59:34, Steve Beattie wrote:
> > By default, statically link against the in-tree libapparmor. If the
> > in-tree libapparmor is not yet built, print a helpful error message. To
> > build against the system libapparmor, the SYSTEM_LIBAPPARMOR make
> > variable can be set on the command line like so:
> > 
> >   $ make SYSTEM_LIBAPPARMOR=1
> 
> I want the "system" variable used for the parser and the regression test
> to be the same and I like USE_SYSTEM better than SYSTEM_LIBAPPARMOR.

I wanted it, too, but wasn't sure how wedded people were to either name.

> Would you mind doing a s/SYSTEM_LIBAPPARMOR/USE_SYSTEM/g on this patch
> (including the commit message) prior to pushing to trunk?

Definitely!

> Everything else looks good!

Thanks for the review.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140106/650706af/attachment.pgp>