This patch fixes up the parser command invocation via
apparmor/common.py:cmd(), as it handles stdout/stderr redirection,
and the redirection that was being attempted were being handed as
arguments to the parser.
(As an aside, we generally try to avoid invoking the shell when running
external commands, to avoid shell quoting issues.)
Signed-off-by: Steve Beattie <steve at nxnw.org>
---
utils/apparmor/tools.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: b/utils/apparmor/tools.py
===================================================================
--- a/utils/apparmor/tools.py
+++ b/utils/apparmor/tools.py
@@ -16,7 +16,7 @@ import sys
import apparmor.aa as apparmor
import apparmor.ui as aaui
-from apparmor.common import user_perm
+from apparmor.common import user_perm, cmd
# setup module translations
from apparmor.translations import init_translation
@@ -118,8 +118,7 @@ class aa_tools:
# One simply does not walk in here!
raise apparmor.AppArmorException('Unknown tool: %s' % self.name)
- cmd_info = apparmor.cmd([apparmor.parser, filename, '-I%s' % apparmor.profile_dir, '-R 2>&1', '1>/dev/null'])
- #cmd_info = apparmor.cmd(['cat', filename, '|', apparmor.parser, '-I%s'%apparmor.profile_dir, '-R 2>&1', '1>/dev/null'])
+ cmd_info = cmd([apparmor.parser, '-I%s' % apparmor.profile_dir, '-R', filename])
if cmd_info[0] != 0:
raise apparmor.AppArmorException(cmd_info[1])
--
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140224/f9496244/attachment.pgp>