[apparmor] new profile tools: preserve full initial comment
Steve Beattie
steve at nxnw.org
Fri Feb 21 18:48:18 UTC 2014
Hey Christian,
My apologies for the delay in reviewing this.
On Wed, Feb 05, 2014 at 11:58:24PM +0100, Christian Boltz wrote:
> while playing with aa-cleanprof, I noticed only the last line of the
> initial comment was preserved.
>
> This patch
> - preserves the complete initial comment
> - makes sure whitespace inside the comment is kept (except leading
> whitespace - line.trim() is still applied).
> - no longer removes the "# vim:syntax" line
>
> Note: I didn't test if handling the "REPOSITORY" line still works (in
> theory it should), but without a working repo, I don't care too much ;-)
Acked-by: Steve Beattie <steve at nxnw.org>, though please kill the
commented out lines before committing. Thanks!
> BTW: It might be a good idea to use a different variable name for the
> result of line.split() to avoid confusion.
Yes, that's a bit confusing.
--
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20140221/9fcb2f41/attachment.pgp>
More information about the AppArmor
mailing list